29 Jan
2021
29 Jan
'21
10:56 a.m.
Attention is currently required from: Sam McNally, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49916 )
Change subject: CHROMIUM: flashrom_tester: Drop nix dependency ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File util/flashrom_tester/src/main.rs:
https://review.coreboot.org/c/flashrom/+/49916/comment/bc510ec4_fd2c9d81 PS1, Line 171: Safe because this doesn't : // modify any memory. nit: put the whole sentence in the next line? This way, the comment block is more rectangular
--
To view, visit https://review.coreboot.org/c/flashrom/+/49916
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If7d1c7c7b5663a32c0a338866f7f7f9bee604cc0
Gerrit-Change-Number: 49916
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Fri, 29 Jan 2021 10:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment