David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35295 )
Change subject: util/git-hooks: Check for Signed-off-by line ......................................................................
util/git-hooks: Check for Signed-off-by line
Enforce the DCO. The logic comes from coreboot's commit-msg hook, and I've added a pointer to flashrom's development guidelines.
Change-Id: Iea49a06c2d4824be073eff98c8aae1cbc5b145e4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M util/git-hooks/commit-msg 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/35295/1
diff --git a/util/git-hooks/commit-msg b/util/git-hooks/commit-msg index 346c08f..fff0e29 100755 --- a/util/git-hooks/commit-msg +++ b/util/git-hooks/commit-msg @@ -28,6 +28,8 @@ CHANGE_ID_AFTER="Bug|Depends-On|Issue|Test|Feature|Fixes|Fixed|Staging-ID" MSG="$1"
+DEV_GUIDELINES_URL="https://www.flashrom.org/Development_Guidelines" + # Check for, and add if missing, a unique Change-Id # add_ChangeId() { @@ -201,8 +203,17 @@ } }
+test_sign_off() { + if ! grep -qi '^[[:space:]]*+Signed-off-by:' "$MSG"; then + printf "\nError: No Signed-off-by line in the commit message.\n" + printf "See: ${DEV_GUIDELINES_URL}\n" + exit 1 + fi +} + main() { test_duplicate_signoffs_acks + test_sign_off add_ChangeId }