Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37406 )
Change subject: dediprog: add serial argument
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/flashrom/+/37406/3/dediprog.c
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/37406/3/dediprog.c@1062
PS3, Line 1062: /* Check if the current device in device_handle has a USB serial
This should be:
/*
* Check if...
https://review.coreboot.org/c/flashrom/+/37406/3/dediprog.c@1238
PS3, Line 1238: if (serial_number
: && !dediprog_is_usb_serial_number(serial_number))
: {
Why isn't this a single line?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/37406
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9cdfbce6cf941c16bf7b7364aa4166b91369e661
Gerrit-Change-Number: 37406
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Inaky Perez-Gonzalez
Gerrit-CC: Inaky Perez-Gonzalez
inakypg@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ryan O'Leary
ryanoleary@google.com
Gerrit-Comment-Date: Sun, 22 Mar 2020 22:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment