Daniel Verkamp has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46310 )
Change subject: pcidev.c: populate IDs with pci_fill_info()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46310/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/46310/1//COMMIT_MSG@10
PS1, Line 10: because the vendor_id and device_id fields of struct
: pci_dev are not filled in
Alright, I see. Could you please add this in the commit message? Thanks.
Sure, I added some more details to the commit message - does this look OK?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia011d4d801f8a54160e45a70b14b740e6dcc00ef
Gerrit-Change-Number: 46310
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Verkamp
dverkamp@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 20:10:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Verkamp
dverkamp@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment