Namyoon Woo has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46536 )
Change subject: dummyflasher.c: Fix null par data and size param handling ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@7 PS1, Line 7: fixes on VARIABLE_SIZE chip support
dummyflasher. […]
Done
https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@10 PS1, Line 10: (https://review.coreboot.org/c/flashrom/+/44879
Could you use the commit hashes instead of the links like […]
Done
https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@13 PS1, Line 13: - dummy_init() used to fail for the absence of "size" argument, which broke : the run on non VARIABLE_SIZE emulation target. Now the run fails : without "size" only for VARIABLE_SIZE.
Format these with an indent `*`. […]
Done
https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@16 PS1, Line 16: - probe_variable_size() used to fail if the bus type is either PARALLEL, LPC or FWH : because flash->mst->par.data is null. Now dummy_init() sets up par_master_dummy.data
- probe_variable_size() should fail if bus type is 'PARALLEL, LPC or FWH' however 'flash->mst->par. […]
probe_variable_size() should NOT fail whatever the bus type is. But the patch '3b8fe0f8e907c0ba9f7c7935e950f3e1538d427f' neglected to initialize 'flash->mst->par.data', and it broke the VARIABLE_SIZE dummy flash run.
https://review.coreboot.org/c/flashrom/+/46536/1//COMMIT_MSG@20 PS1, Line 20: - man page is revised to describe how to use VARIABLE_SIZE emulation : target.
- Revise man page to describe how to use the VARIABLE_SIZE emulation target.
Done
https://review.coreboot.org/c/flashrom/+/46536/1/flashrom.8.tmpl File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/46536/1/flashrom.8.tmpl@658 PS1, Line 658: , which is a power of two.
as a power of two.
Done