Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/20506 )
Change subject: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode
......................................................................
Patch Set 3: Code-Review+1
Tested okay with both internal flash and ftdi_spi google-servo-v2. Flash with flashrom and then read back from dediprog, the content is identical.
--
To view, visit
https://review.coreboot.org/20506
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I90226f453f8147ae5ac7dbbef7549ee3bfacc3d6
Gerrit-Change-Number: 20506
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philippe Mathieu-Daudé
f4bug@amsat.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Stefan Tauner
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Sep 2017 01:27:32 +0000
Gerrit-HasComments: No