[flashrom-gerrit] [XS] Change in flashrom[main]: flashchips: Correct feature_bits for MX25L128*

[Hsuan-ting Chen (Code Review)]

Attention is currently required from: Hsuan Ting Chen.

Hello Hsuan Ting Chen,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/flashrom/+/82605?usp=email

to review the following change.

Change subject: flashchips: Correct feature_bits for MX25L128*
......................................................................

flashchips: Correct feature_bits for MX25L128*

In CB:81792 (CL:5471748) we add write-protect support for MX25L12833F,
MX25L12835F/MX25L12873F, and MX25L12845E/MX25L12865E.

However, that CL contained a bug that it didn't set the feature_bits
correctly. We need to add:

* Add FEATURE_CFGR and FEATURE_SCUR for MX25L12833F
* Add FEATURE_CFGR and FEATURE_SCUR for MX25L12835F/MX25L12873F
* Add FEATURE_SCUR for MX25L12845E/MX25L12865E

BUG=b:332486637
TEST=In a host connect to ADL-n ChromeOS via servo, with this patch,
     flashrom -p raiden_debug_spi:target=AP,custom_rst=true
     ,serial=$(dut-control -o ccd_serialname -p 9996) --wp-status
     returns correct WP status.
TEST=without this patch, returns error with
     "Cannot read SECURITY: unsupported by chip"

Change-Id: I001cde6816bd099317bc9c23904c5fcbe6003241
Signed-off-by: Hsuan Ting Chen 
---
M flashchips.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/82605/1

diff --git a/flashchips.c b/flashchips.c
index 59edeb3..d5b63e9 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -9012,7 +9012,7 @@
    	.total_size	= 16384,
    	.page_size	= 256,
    	/* OTP: 1KB total; enter 0xB1, exit 0xC1 */
-		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP,
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_CFGR | FEATURE_SCUR,
    	.tested		= TEST_OK_PREWB,
    	.probe		= PROBE_SPI_RDID,
    	.probe_timing	= TIMING_ZERO,
@@ -9059,7 +9059,7 @@
    	.total_size	= 16384,
    	.page_size	= 256,
    	/* OTP: 512B total; enter 0xB1, exit 0xC1 */
-		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP,
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_CFGR | FEATURE_SCUR,
    	.tested		= TEST_OK_PREW,
    	.probe		= PROBE_SPI_RDID,
    	.probe_timing	= TIMING_ZERO,
@@ -9106,7 +9106,7 @@
    	.total_size	= 16384,
    	.page_size	= 256,
    	/* OTP: 512B total; enter 0xB1, exit 0xC1 */
-		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP,
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_SCUR,
    	.tested		= TEST_OK_PREW,
    	.probe		= PROBE_SPI_RDID,
    	.probe_timing	= TIMING_ZERO,