Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )
Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47655/8/it85spi.c
File it85spi.c:
https://review.coreboot.org/c/flashrom/+/47655/8/it85spi.c@240
PS8, Line 240: (struct it85spi_data *)
Tracking towards general kernel style is a compelling reason to go that route. […]
Compiler is not cooperative:
error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
So I am keeping the cast
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47655
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I389d34d62e753c012910aa5ff24a496b24a4753c
Gerrit-Change-Number: 47655
Gerrit-PatchSet: 9
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Eizan Miyamoto
eizan@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Dec 2020 03:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment