Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )
Change subject: ft2232_spi: reintroduce generic GPIOL control ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57810/comment/4d67914b_89f55268 PS2, Line 22: : TODOs: : - discuss merging `csgpiol` into `gpiol` as 'C' (see RFC comment) : - reword commit message : - man page for both `csgpiol`, `gpiol` : TODOs
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/790514e5_9e1e8bca PS2, Line 530: /* * * * * * * * * * * * * * * * * * * * * * * * * * * : * REQUEST FOR COMMENTS: 'C' could replace `csgpiol` * : * * * * * * * * * * * * * * * * * * * * * * * * * * */ : case 'C': : cs_bits |= 1 << gpiol_pin; : pindir |= 1 << gpiol_pin; : break; : RFC: 'C' could replace `csgpiol`
Example: `csgpiol=2` would become `gpiol=XXCX`