27 May
2021
27 May
'21
10:24 a.m.
Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54994 )
Change subject: mcp6x_spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File mcp6x_spi.c:
https://review.coreboot.org/c/flashrom/+/54994/comment/dc53e92c_faf2f831 PS1, Line 42: uint8_t mcp_gpiostate; I'd rename the struct members to drop the `mcp6x` and `mcp` prefixes. Since this patch already touches the code, one might as well do it as part of this commit.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54994
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia02c1cb9d36fb7b15bb7e09b769d8969c08c2bd5
Gerrit-Change-Number: 54994
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 27 May 2021 10:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment