17 Nov
2022
17 Nov
'22
5:39 a.m.
Attention is currently required from: Edward O'Callaghan.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69401 )
Change subject: flashrom_tester: Simplify WriteProtectState ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69401/comment/b92c4e41_1db694c4 PS4, Line 9: We are not using push() anywhere so remove that. Drop the Mutex, rely on : callers not doing it wrong.
Just update the commit message to elaborate on the technical trade off's here between the multi laye […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/69401
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c4251f69b42a327383b8a99fa933f411feb9568
Gerrit-Change-Number: 69401
Gerrit-PatchSet: 5
Gerrit-Owner: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 17 Nov 2022 05:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment