Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro
......................................................................
Patch Set 5:
(3 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/253b1618_839bf88c
PS5, Line 141: 2 bits
Can you elaborate more than just saying 2 bits so to help the reader who may not have access to the […]
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/82648ad5_38b9cc2b
PS5, Line 143: 1-2: FLASH Cycle
`1-n: FLASH Cycle`
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/537ffb33_a23279a1
PS5, Line 145: #define HSFC_FCYCLE (0x3 << HSFC_FCYCLE_OFF)
isn't this removable now since you would have […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id222304165610c7ae48e365d72ec8fdeea51c51d
Gerrit-Change-Number: 62891
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 18:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment
