Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/74924 )
Change subject: makefile: remove gitconfig target ......................................................................
makefile: remove gitconfig target
There's basically no benefit to running `make` over directly running the script that configures hooks, and implementing similar support in Meson is difficult. Remove the Makefile target and make documentation point to the script it runs instead to achieve feature parity between the build systems.
Signed-off-by: Peter Marheine pmarheine@chromium.org Change-Id: I278408bd515c5a5599b5c45c597cc66485a87082 --- M Makefile M doc/dev_guide/contributing.rst 2 files changed, 17 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/74924/1
diff --git a/Makefile b/Makefile index 0e16942..794855e 100644 --- a/Makefile +++ b/Makefile @@ -1100,9 +1100,6 @@ libpayload: clean make CC="CC=i386-elf-gcc lpgcc" AR=i386-elf-ar RANLIB=i386-elf-ranlib
-gitconfig: - ./util/getrevision.sh -c 2>/dev/null && ./util/git-hooks/install.sh - .PHONY: all install clean distclean config _export export tarball libpayload
# Disable implicit suffixes and built-in rules (for performance and profit) diff --git a/doc/dev_guide/contributing.rst b/doc/dev_guide/contributing.rst index 0a4e452..cd63f65 100644 --- a/doc/dev_guide/contributing.rst +++ b/doc/dev_guide/contributing.rst @@ -183,7 +183,7 @@ Pushing patches ---------------
-1. Install Git hooks: :code:`make gitconfig` +1. Install Git hooks: :code:`./util/git-hooks/install.sh`
2. Add upstream as a remote: * If using SSH: :code:`git remote add -f upstream ssh://<gerrit_username>@review.coreboot.org:29418/flashrom`