Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41622 )
Change subject: tests/: Add CMocka unit-test infrastructure ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/41622/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41622/3//COMMIT_MSG@10 PS3, Line 10: meson
Only meson? It would be nice to handle the "we have two build systems" problem someday. […]
I can follow up with something for the Makefile once we get this initial attempt into shape by taking out any of the major issues if any?
I'll follow up with Patrick or Stefan about the buildbot as we definitely want to have it run the unit-tests once they are merged. I think we should have the buildbot build with meson as well.
https://review.coreboot.org/c/flashrom/+/41622/3/tests/include/test.h File tests/include/test.h:
https://review.coreboot.org/c/flashrom/+/41622/3/tests/include/test.h@2 PS3, Line 2: /* This file is part of the coreboot project. */
This was dropped in upstream coreboot
I think it is pretty useful here unless I am missing a good reason to get rid of it?
https://review.coreboot.org/c/flashrom/+/41622/3/tests/tests.c File tests/tests.c:
PS3:
No license headers here?
Done