4 Oct
2019
4 Oct
'19
2:14 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35480 )
Change subject: flashchips.c: Add GD25Q256D from downstream ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35480/6/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/35480/6/flashchips.c@6285 PS6, Line 6285: _WREN Are we sure about this? the datasheet explicitly mentions the sequence:
CS# goes low -> sending Enter 4-Byte mode command -> CS# goes high.
--
To view, visit https://review.coreboot.org/c/flashrom/+/35480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I79d4ed48aa9126a8a6ce455a9564451346195b8f
Gerrit-Change-Number: 35480
Gerrit-PatchSet: 6
Gerrit-Owner: Alan Green avg@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 14:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment