Attention is currently required from: Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/69399?usp=email )
Change subject: spi25_statusreg: make "configuration registers" an alias to SRs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The change was requested during review of CB:66211. […]
Thanks for details! I reviewed the patch now, and I don't want it :)
There have been lots of chips added with WP support since that time, it's probably too late to change.
Also I am reviewing most of the patches into flashchips, I see that contributors have no troubles understanding current configuration, everyone got used to it.
Let's keep what we have now, I will abandon the patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69399?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I27e89626037dcb0ed078029efe1e919b1f3e88fe
Gerrit-Change-Number: 69399
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sun, 22 Sep 2024 08:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com