27 Jan
2019
27 Jan
'19
9:33 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 )
Change subject: ichspi: Add Apollo Lake support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: ME
On APL this region should be empty on production devices. The TXE is inside the IFWI. […]
Maybe name it ROMB on APL? But again, APL-specific naming seems to be not trivial to implement.
And anyone who is working with APL stuff should bear this in mind anyway, so I don't think leaving the name as ME/TXE is too much of an issue.
--
To view, visit https://review.coreboot.org/c/flashrom/+/30995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c464b5b3d151e6d28d5db96495fe874a0a45718
Gerrit-Change-Number: 30995
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Jan 2019 08:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment