Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67073 )
Change subject: usb_device.c: detach/attach usb kernel driver explicitly
......................................................................
Patch Set 3:
(1 comment)
File usb_device.c:
https://review.coreboot.org/c/flashrom/+/67073/comment/02d0d0e0_e58e6988
PS2, Line 349: libusb_error_name(ret));
but there is no raiden/servo kernel driver on FreeBSD afaik not that should block this in the generi […]
The `LIBUSB_ERROR_NOT_SUPPORTED` makes this code run on FreeBSD. Their libusb implementation does not support detaching a kernel driver and returns `LIBUSB_ERROR_NOT_SUPPORTED` in any case.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1363fea13368b7ac1e9a3829864d06d123c4e157
Gerrit-Change-Number: 67073
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 05 Sep 2022 11:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment