Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 5:
(4 comments)
Patchset:
PS1:
A comment for me to add item to "Recent development" doc after the review
Done
Patchset:
PS3:
I think this warrants an entry in the release notes too, since it's a user-visible change.
Yes, I added a comment to myself to do this :) and now I resolved both comments
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/7a6329f6_26c5c243?usp... : PS2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead
The old version was usable but required global state. […]
This is so clever! I didn't realise there was such a way of using the old API. I even mentioned this in the recent development notes :)
So, just to clarify: do you think it is unavoidable to keep the old deprecated function code, and two callbacks in flash context? One callback is better than two: but my main goal is to have a new API, so if keeping the old is a required step, I will do it.
Also who are the users for whom it makes a difference, is that the users who build with old header and new code?
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86031/comment/e9295642_5f760a0e?usp... : PS3, Line 71: msg_gerr("%s deprecated, use flashrom_set_progress_callback_v2 instead\n", __func__);
This message will probably be shown to users more often than developers (who should see the warning […]
Done