Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58735 )
Change subject: ichspi: Split very long init function into two ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58735/comment/55bb6606_74c419af PS3, Line 20: TEST=1) probe-read-verify-erase section-write-reboot : on Intel octopus board with GD25LQ128C/GD25LQ128D/GD25LQ128E : 2) probe and read on Panther Point (7 series PCH) Did I do the right by adding test info into commit message? Do I need to added Tested-By tags? I don't know whether I can add Tested-By tag for another person not me?
Patchset:
PS3: I tested this with latest changes and updated commit message. It was lots of pain to merge this into chromium tree for testing :`( I need to / I have to improve the situation next year...
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/58735/comment/3a3ef2c3_d647f146 PS2, Line 1822: arg = extract_programmer_param("ich_spi_mode");
I use a very stupid trick to minimise diffstat noise when reindenting blocks of code during refactor […]
Wow! this is great idea, I might use it in future, thank you!! I would leave this commit as is, hope it's fine.
https://review.coreboot.org/c/flashrom/+/58735/comment/49a8c090_c21a6070 PS2, Line 1769:
I'd normally complain about unrelated whitespace changes (this seems accidental), but addressing thi […]
Yes this was accidental, I removed it.