24 Sep
2019
24 Sep
'19
9:02 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35561 )
Change subject: util/getversion,meson: Add script to allow version info with Meson ......................................................................
Patch Set 1:
Sure seems fine by me. Go head and add this to your CL as you see fit.
IMHO, it's an orthogonal change and belongs into it's own commit. Also, it was your idea, I don't see why you shouldn't have the honor :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/35561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I401e5638509c4a573bc0cb17ebc5fa76df9700b5
Gerrit-Change-Number: 35561
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Mario Limonciello superm1@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Sep 2019 21:02:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment