Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 )
Change subject: libflashrom,writeprotect: add flashrom_wp_get_available_ranges() ......................................................................
Patch Set 44:
(4 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58481/comment/fac80b07_a558635e PS44, Line 189: /* For equal length ranges, list the one with a lower start address */ : /* first. */ This looks like a multiline comment pretending to be two single-line comments in a row :) Probably should be an actual multi-line comment?
https://review.coreboot.org/c/flashrom/+/58481/comment/8b27163a_33ea8178 PS44, Line 194: /* Ranges a and b are identical, order them by the values of the bits */ : /* that are used to select them. */ And this one too
https://review.coreboot.org/c/flashrom/+/58481/comment/d48fd7b8_4376dfa7 PS44, Line 267: /* Enumerate all values the range bits can take and find the range */ : /* associated with each one. */ And this one too
https://review.coreboot.org/c/flashrom/+/58481/comment/56a6574a_493e6829 PS44, Line 270: /* Extract bits from the range index and assign them to members */ : /* of the wp_bits structure. */ And this one