[flashrom-gerrit] Change in flashrom[master]: it85spi.c: Refactor singleton states into reentrant pattern

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )

Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 11:

(1 comment)

File it85spi.c:

https://review.coreboot.org/c/flashrom/+/47655/comment/46ae3219_9922316a 
PS11, Line 59: /* IT8502 supports two access modes:
             :  *   LPC_MEMORY: through the memory window in 0xFFFFFxxx (follow mode)
             :  *   LPC_IO: through I/O port (so called indirect memory)
             :  */
             : #undef LPC_MEMORY
             : #define LPC_IO
this would need to be moved above the initial guard, the slightly better fix is that the Makefile pass `-DLPC_MEMORY` or `-DLPC_IO` to compile the file with the correct configuration. It's all a bit awful.