Antonio Ospite has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt
......................................................................
Patch Set 10:
(1 comment)
Just a minor comment on the commit message.
Keep up the good work!
https://review.coreboot.org/c/flashrom/+/35591/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/35591/10//COMMIT_MSG@17
PS10, Line 17: v.6: Use printf() directly.
Hi Edward,
IMHO it is not necessary to put the review history in commit messages.
And even less so in a gerrit workflow as it's all in gerrit already, right?
Ciao, Antonio
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56
Gerrit-Change-Number: 35591
Gerrit-PatchSet: 10
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Antonio Ospite
ao2@ao2.it
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 20:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment