Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82496?usp=email )
Change subject: Correct get_flash_region() to use inclusive upper bounds ......................................................................
Patch Set 4:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/82496/comment/65a8f8c6_37450783?usp... : PS2, Line 1518: region.end - 1
`region. […]
Done
https://review.coreboot.org/c/flashrom/+/82496/comment/184f6c4c_0bc70ec3?usp... : PS2, Line 1524: region.end - 1
also `region. […]
Done
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/82496/comment/7694afec_9848bf71?usp... : PS2, Line 1454: limit
Why you are changing this? I understand why region end changes, but why region start? […]
Good catch; it should still be +1 here. The regions in this function also use inclusive bounds so converting from the top to bottom needs an adjustment, but I probably failed to think that through completely.