Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47452 )
Change subject: spi25.c: Improve spi_simple_write_cmd() diags and readability
......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
I don't see the point of explicitly initializing the read members of a write command.
It just makes the file more consistent to read as well as help static analyzers.
https://review.coreboot.org/c/flashrom/+/47452/1/spi25.c
File spi25.c:
https://review.coreboot.org/c/flashrom/+/47452/1/spi25.c@354
PS1, Line 354: .readarr = 0,
What about these?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9fc82558035e511ee485fb5aab0bcd3e164c6ba
Gerrit-Change-Number: 47452
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 11:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment