Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39532 )
Change subject: flashchips: Add Macronix MX25R3235F ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Just a few comments on the commit message. I'm sorry that it took me so long to review.
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@9 PS1, Line 9: 4MB That would be 4 MiB, actually.
Another option would be to omit the paragraph instead. The URL is rather long, could change over time, and the flash chip information is in the code anyway
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@12 PS1, Line 12: Similar to already supported MX25R6435F, just half the size. Make this a sentence, for example:
It is similar to the already-supported MX25R6435F, but the total size is halved.
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@14 PS1, Line 14: 4232H Did you mean "FT4232H" and "FT2232H" ?
https://review.coreboot.org/c/flashrom/+/39532/1//COMMIT_MSG@15 PS1, Line 15: & just "and"