Konstantin Grudnev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34496 )
Change subject: Add support for M95M02-A125 ......................................................................
Patch Set 4:
(3 comments)
fixed
https://review.coreboot.org/c/flashrom/+/34496/4/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/34496/4/flashchips.h@855 PS4, Line 855: /* 00h ST Manufacturer code ST_ID*/ : /* 01h SPI Family code 0x00*/ : /* 02h Memory Density code ST_M95XXX */
This is just like it always is, imho, no need for this comment. […]
Done
https://review.coreboot.org/c/flashrom/+/34496/4/spi95.c File spi95.c:
https://review.coreboot.org/c/flashrom/+/34496/4/spi95.c@8 PS4, Line 8: version 3
ugh, this is incompatible with much of flashrom (some parts are version 2 […]
Done
https://review.coreboot.org/c/flashrom/+/34496/4/spi95.c@59 PS4, Line 59:
Nit, still a spurious space after the closing parenthesis.
Done