4 Jul
2021
4 Jul
'21
12:27 p.m.
Attention is currently required from: Felix Singer, Daniel Maslowski, Sophie van Soest, Paul Menzel. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 )
Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter. ......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56055/comment/3ba2193a_639ad323 PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
From this headline one can not relate that you are marking Z97 as OK. […]
Simple rule: if the changes can stand on their own, split them
--
To view, visit https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 8
Gerrit-Owner: Sophie van Soest sophie@entropie.rocks
Gerrit-Reviewer: Daniel Maslowski info@orangecms.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Daniel Maslowski info@orangecms.org
Gerrit-Attention: Sophie van Soest sophie@entropie.rocks
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 04 Jul 2021 12:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Sophie van Soest sophie@entropie.rocks
Gerrit-MessageType: comment