8 Oct
2022
8 Oct
'22
8:18 a.m.
Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68231 )
Change subject: rayer_spi.c: Move rget_io_perms() check to pre-amble ......................................................................
Patch Set 1:
(1 comment)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68231/comment/33301c6a_1c34a8b9 PS1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0) Hmmm, does it make sense to get I/O perms before parsing programmer params?
--
To view, visit https://review.coreboot.org/c/flashrom/+/68231
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc
Gerrit-Change-Number: 68231
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Sat, 08 Oct 2022 08:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment