Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37372 )
Change subject: print.c: Fix pp str format alignment in print_supported_boards_helper()
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
(1 comment)
I like the idea of aligning to tabs, but I think that will require a lot more effort to fix the output. I tested an alternative approach (linked in the comment, along with a longer explanation).
Regardless thanks for the quick review! I looked over your patch and seems good to me.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/37372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic25512bc6f31e62dfc77e32a4c71519bdde01598
Gerrit-Change-Number: 37372
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Dec 2019 03:00:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment