Nico Huber has posted comments on this change. ( https://review.coreboot.org/18962 )
Change subject: ichspi: Add support for Intel Skylake ......................................................................
Patch Set 9:
Ah, right... That's something I fixed in the CrOS tree a while back: https://chromium-review.googlesource.com/c/448165
Hmmm, that change made sense for the weird cros code (where the 100series support was a copy-paste of the old code), but here we share 90% of the code paths and I'd rather keep it like that.
Maybe we can just add a comment for now so it's obvious to forgetful people reviewing the code? Or we can follow-up with a patch to match the datasheet conventions.
I'd prefer a comment. Or maybe make it more obvious in the code itself, like writing `17 - 16` instead of `1`. How about that?