27 Sep
2022
27 Sep
'22
4:57 p.m.
Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Khoa Hoang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713 )
Change subject: flashchips.c: Add write protect support for W25Q16.V ......................................................................
Patch Set 4:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/67713/comment/6e1b632b_05dece13 PS4, Line 17543: .sec = {STATUS1, 6, RW},
Maybe we should add `. […]
I just check the datasheet for W25Q16DV and it doesn't support that register bit. Datasheet only mention status1,2 and I don't think it support wps bit.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
Gerrit-Change-Number: 67713
Gerrit-PatchSet: 4
Gerrit-Owner: Khoa Hoang admin@khoahoang.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Tue, 27 Sep 2022 16:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Gerrit-MessageType: comment