Attention is currently required from: David Hendricks, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31016 )
Change subject: hwaccess: Add endianness converting deserialization functions
......................................................................
Patch Set 8:
(1 comment)
File hwaccess.h:
https://review.coreboot.org/c/flashrom/+/31016/comment/38e43741_e82f6392
PS8, Line 116: return endianness##_to_cpu##bits(*(uint##bits##_t *)from); \
I've just noticed that we have unaligned reads in FMAP. So technically,
we should read the value byte-by-byte and not with a blunt pointer
dereference. Most platforms will handle this gracefully for us. So
maybe we can just wait if anybody complains ;)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/31016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452
Gerrit-Change-Number: 31016
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 12:58:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment