Attention is currently required from: Felix Singer, Gaggery Tsai, Tim Crawford, Matt DeVillier, Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37677 )
Change subject: chipset_enable.c: Add CMP-H IDs
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Patch Set 1:
Thanks for your patch!
I couldn't find a SPI Guide for CMP-H. Nowadays it's part of the
ME Kit, but there seems to be none yet.
Judging from the CMP-LP guide, there may be little changes to the
FLMAP* fields in the descriptor. It would be nice to know if there
were also changes for CMP-H and have ich_descriptors.* updated in
case. We might have to add it as CHIPSET_400_SERIES_...
Looks like this is still unattended. I've access to a CMP-H
SPI guide now and there is (same as for the -LP) an FLMAP3
with version information.
Please check descriptor dumps and update the code accordingly.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/37677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic7f04fc5cbe3422cbd219c46586c32fc847c921f
Gerrit-Change-Number: 37677
Gerrit-PatchSet: 5
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 23 Apr 2021 11:48:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment