27 Jul
2021
27 Jul
'21
2:37 a.m.
Attention is currently required from: Nico Huber. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56466 )
Change subject: programmer.h: Minor tidy up ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Do we need any of the #ifdef at all?
Very likely not in most cases. I rather we just let the linker do its job which I think you are suggesting here? Do we want to tear them out in this same patch as some pre-process is needed here?
File programmer.h:
https://review.coreboot.org/c/flashrom/+/56466/comment/1012c8d0_91fa4f85 PS2, Line 477: remove extra \n
--
To view, visit https://review.coreboot.org/c/flashrom/+/56466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77
Gerrit-Change-Number: 56466
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 27 Jul 2021 02:37:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment