David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43051 )
Change subject: serial: Fix file read/write error handling for Windows
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/43051/1/serial.c
File serial.c:
https://review.coreboot.org/c/flashrom/+/43051/1/serial.c@494
PS1, Line 494: != true
I'd just go without any comparisons: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/43051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib179d51ede2dbd38f54f3641bfe90340a6a87e31
Gerrit-Change-Number: 43051
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 04 Jul 2020 16:54:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment