Attention is currently required from: Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67310 )
Change subject: tests: Use MOCK_FD instead of NON_ZERO for file operations
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67310/comment/d2f9e2c8_f3dde907
PS2, Line 15: FreeBSD 13.1-RELEASE-p2 GENERIC amd64
The patch sets are in wrong order for this. […]
My mistake was to copy-paste the same test info for all 3 patches, sorry. Patches can probably go in any order, but all of them needed to run the tests on freebsd, so tests can run at the end of the chain (not in the middle).
I updated commit messages, hopefully they are not misleading anymore.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I097dd59f69c3fb532ac136796fcf5cae8839af7b
Gerrit-Change-Number: 67310
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Wed, 07 Sep 2022 00:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment