Attention is currently required from: Felix Singer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68230 )
Change subject: rayer_spi.c: Move param parse logic into own func ......................................................................
Patch Set 1:
(1 comment)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68230/comment/19009ea2_77c475f4 PS1, Line 292: if (prog_type) { : for (; prog->type != NULL; prog++) { : if (strcasecmp(prog_type, prog->type) == 0) { : break; : } : } : free(prog_type); : : if (prog->type == NULL) { : msg_perr("Error: Invalid device type specified.\n"); : return 1; : } : }
No, actually I didn't push CB:68238 before which made it unclear what I was thinking. […]
The idea is that the `prog_type` string isn't needed in the init code. So, instead of obtaining the `prog_type` string from `get_params()`, you could obtain `prog` directly.