7 Mar
2023
7 Mar
'23
6:24 a.m.
Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions ......................................................................
Patch Set 3:
(1 comment)
File doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/084a0d73_88a30cf4 PS1, Line 206: To get a code coverage report
Ack
Maybe it's just me, but original instructions feel easier to understand and follow. Maybe keep them as is ? (I am specifically talking about coverage section). Also llvm section is now missing, it seems. I would just copy the instructions...
--
To view, visit https://review.coreboot.org/c/flashrom/+/73359
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324
Gerrit-Change-Number: 73359
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 07 Mar 2023 06:24:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment