Attention is currently required from: Arthur Heymans, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57633 )
Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
This looks like it suffers from the same problem as another patch that
I gave a -2 for a reason. You indirectly change paths (look at what
cases hit GEMINILAKE for instance) without noticing.
The current patch also changes when the warning is printed (not anymore
for ISL < 16) while the commit message states otherwise.
If I had the time to further attend this, it would get another -2.
Please slow down. You are really forcing me to look into things I
don't want to but evidently have to to prevent further breakage.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57633
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52
Gerrit-Change-Number: 57633
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: David Hendricks
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Tue, 14 Sep 2021 10:20:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment