Miriam Polzer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Missing headers? Was something broken?
It was broken until platform.h was added to flash.h, yes. I'd like to avoid transitive includes that's why I'm adding the inlcude everwhere now. Otherwise somebody might break this unknowingly again by removing the include in flash.h or somewhere else.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/48880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If17a3d58c02222f61b4e0335879eeed1638b583c
Gerrit-Change-Number: 48880
Gerrit-PatchSet: 1
Gerrit-Owner: Miriam Polzer
mpolzer@google.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
edward.ocallaghan@koparo.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Dec 2020 08:33:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment