Attention is currently required from: Sam McNally, Edward O'Callaghan.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63902 )
Change subject: raiden_debug_spi.c: Document where raiden_debug_spi_requests are handled
......................................................................
Patch Set 1:
(1 comment)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/63902/comment/6a6e88c0_c4a29541
PS1, Line 1450: is handled as a sentinel value that
: * a target value was unspecified
I wouldn't call this a sentinel; it just means we want to enable it but haven't asked for anything in particular.
REQ_ENABLE doesn't specify a target bus, and will be rejected by adapters that only support one target.
perhaps?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8cc78a85660190c9f750bf67994f0d59d69592d8
Gerrit-Change-Number: 63902
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Thu, 28 Apr 2022 03:53:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment