Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 )
Change subject: meson: add option to disable tests
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63832/comment/9a4bb66b_addca0bd
PS6, Line 11: to
To
Done
https://review.coreboot.org/c/flashrom/+/63832/comment/712f6d87_010e9746
PS6, Line 12: -
Add a dot at the end.
Done
File meson.build:
https://review.coreboot.org/c/flashrom/+/63832/comment/c9077392_2e3c81d1
PS6, Line 509: # .allowed() is introduced in 0.59.0
Oh, sorry. Somehow I thought the comment is related to that .enabled. My fault. […]
I've updated the comment. The code is IMO the right place to document non expecting behavior like this workaround to keep the minimum required meson version as low as possible.
Is this ok now?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b
Gerrit-Change-Number: 63832
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 21:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment