2 Nov
2021
2 Nov
'21
2:29 a.m.
Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 )
Change subject: [RFC] writeprotect: implement wp_get_ranges() ......................................................................
Patch Set 6:
(1 comment)
File writeprotect.h:
https://review.coreboot.org/c/flashrom/+/58481/comment/ee654d82_cfae3ba8 PS6, Line 57: wp_get_ranges
"get_range_list" is better than "get_ranges", but still might suggest multiple ranges rather than a […]
I would suggest to have some Doxygen style comments on the parameters to avoid any confusion from just the symbol name alone. Also we want this for exposing via libflashrom.h
--
To view, visit https://review.coreboot.org/c/flashrom/+/58481
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d
Gerrit-Change-Number: 58481
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 01:29:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Comment-In-Reply-To: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment