28 Sep
2021
28 Sep
'21
10:49 a.m.
Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57990 )
Change subject: custom_baud: move Linux specific code into own file ......................................................................
Patch Set 4:
(2 comments)
File custom_baud.c:
https://review.coreboot.org/c/flashrom/+/57990/comment/38bc7e02_a49370b4 PS3, Line 17: #include "custom_baud.h"
I guess this was only on top because of the #if later. Generally <> includes […]
Done
File custom_baud_linux.c:
https://review.coreboot.org/c/flashrom/+/57990/comment/b123a575_ee61d800 PS3, Line 17: #include "custom_baud.h"
Same here, please move blow the <> includes.
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/57990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0744e769dcc6000483e7256105903a87e927ee77
Gerrit-Change-Number: 57990
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 28 Sep 2021 10:49:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment