Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/3/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/3/cli_classic.c@626
PS3, Line 626: goto out_shutdown;
Nit: This could go outside of the if/else scope
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56
Gerrit-Change-Number: 35591
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Sep 2019 14:13:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment