[flashrom-gerrit] [L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master

[Jonathon Hall (Code Review)]

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev.

Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/67695

to look at the new patch set (#6).

Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master
......................................................................

drivers: Move (un)map_flash_region from programmer to par/spi_master

Move (un)map_flash_region function pointers from programmer_entry to
par_master and spi_master.  Some programmers (internal) need to specify
different mappers per bus master, and no opaque masters require a
mapper.  Mapping is closely tied to the way the memory is accessed
using the other functions in par_master/spi_master.

ICH SPI internal programming now works with flash >16 MB.  Previously
it would fail due to attempting to mmap 32 MB or more, which is not
possible as only the top 16 MB of flash is mapped into the address
space.

Validate that FWH/LPC programmers provide specialized mapping in
register_par_master(); this is needed for chips with
FEATURE_REGISTERMAP, which only exist on FWH or LPC buses.

dummyflasher.c: Use dummy mapper for parallel buses only.

internal.c: Use physmap for parallel and SPI masters only (not opaque
master).  physmap is needed for parallel masters, promontory SPI, and
wbsio SPI.  Fallback must be used for ICH opaque master to allow use
> 16 MB flash.  physmap is probably unneeded for other SPI masters but

is preserveded since they were not tested.

serprog.c: Replace mapper hack for 16 MB limit with max_rom_decode.

programmer.c: Update comment in fallback_map(), NULL return is the
desired behavior.

Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b
Signed-off-by: Jonathon Hall 
---
M atahpt.c
M atapromise.c
M atavia.c
M buspirate_spi.c
M ch341a_spi.c
M dediprog.c
M developerbox_spi.c
M digilent_spi.c
M drkaiser.c
M dummyflasher.c
M flashrom.c
M ft2232_spi.c
M gfxnvidia.c
M hwaccess_physmap.c
M ichspi.c
M include/flash.h
M include/hwaccess_physmap.h
M include/programmer.h
M internal.c
M it8212.c
M it87spi.c
M jlink_spi.c
M linux_mtd.c
M linux_spi.c
M mediatek_i2c_spi.c
M mstarddc_spi.c
M ni845x_spi.c
M nic3com.c
M nicintel.c
M nicintel_eeprom.c
M nicintel_spi.c
M nicnatsemi.c
M nicrealtek.c
M ogp_spi.c
M parade_lspcon.c
M parallel.c
M pickit2_spi.c
M pony_spi.c
M programmer.c
M raiden_debug_spi.c
M rayer_spi.c
M realtek_mst_i2c_spi.c
M satamv.c
M satasii.c
M sb600spi.c
M serprog.c
M stlinkv3_spi.c
M usbblaster_spi.c
M wbsio_spi.c
49 files changed, 141 insertions(+), 116 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/6