Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call to save programming time ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@7 PS8, Line 7: to save programming time Omit this part from the commit summary
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@9 PS8, Line 9: Every ftdi_write_data() call is quite time consuming as the ftdi-chips seems to take always 2-3ms to respond. Please split these lines so that they aren't longer than 72 characters
https://review.coreboot.org/c/flashrom/+/40477/8//COMMIT_MSG@17 PS8, Line 17: https://ibb.co/0c1J25d These links will stop working at some point.