Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33343 )
Change subject: atavia.c: Remove unneeded 'else'
......................................................................
Patch Set 1:
(1 comment)
Can we discuss this first? How is not having the `else`
better? The `continue` on the else path also wasn't
necessary, but I assume the author put it there to
balance the branches, for better legibility.
https://review.coreboot.org/#/c/33343/1/atavia.c
File atavia.c:
https://review.coreboot.org/#/c/33343/1/atavia.c@107
PS1, Line 107: continue;
This is... well, looks just wrong.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib43a8c186c34c85f964df648564fa7f5aef10412
Gerrit-Change-Number: 33343
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 09 Jun 2019 21:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment